[dpdk-dev] [PATCH 4/4] eal/x86: implement arch-specific TSC freq query

Thomas Monjalon thomas at monjalon.net
Fri Oct 13 09:30:43 CEST 2017


13/10/2017 05:47, Stephen Hemminger:
> On Fri, 13 Oct 2017 02:02:47 +0200
> Thomas Monjalon <thomas at monjalon.net> wrote:
> 
> > +static uint32_t
> > +check_model_wsm_nhm(uint8_t model)
> > +{
> > +	switch (model) {
> > +	/* Westmere */
> > +	case 0x25:
> > +	case 0x2C:
> > +	case 0x2F:
> > +	/* Nehalem */
> > +	case 0x1E:
> > +	case 0x1F:
> > +	case 0x1A:
> > +	case 0x2E:
> > +		return 1;
> > +	}
> > +
> > +	return 0;
> > +}
> 
> How about a table rather than switch?
> Also bool rather than int?

It is a matter of taste :)
I plan to push it as is. It can be changed later if desired.


More information about the dev mailing list