[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type

Yang, Zhiyong zhiyong.yang at intel.com
Thu Oct 19 02:55:40 CEST 2017


Hi Pablo,

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, October 18, 2017 9:10 PM
> To: Yang, Zhiyong <zhiyong.yang at intel.com>; dev at dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; Yang, Zhiyong
> <zhiyong.yang at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type
> 
> Hi Zhiyong,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhiyong Yang
> > Sent: Wednesday, October 18, 2017 10:50 AM
> > To: dev at dpdk.org
> > Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; Yang, Zhiyong
> > <zhiyong.yang at intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type
> >
> > Fix port id issue and remove unnecessary cast.
> >
> > Fixes: f8244c6399d9 ("ethdev: increase port id range")
> > Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>
> 
> Actually, I think we can extend this patch to declare all variables related to port
> ids to uint16_t.
> I have seen the following: "l2fwd_dst_ports", "portid", "dest_portid", "dst_port".
> 
> Rest of the patch looks good to me, so you can keep the ack if you are doing a
> v2.
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> 

Thanks for your review and acked by.  I can do as you comment in V2.

zhiyong



More information about the dev mailing list