[dpdk-dev] [PATCH v4 09/12] mk: add rte security into build system

Thomas Monjalon thomas at monjalon.net
Fri Oct 20 13:06:27 CEST 2017


Why not merging this patch with the first one?

> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +Security API - EXPERIMENTAL
> +M: Akhil Goyal <akhil.goyal at nxp.com>
> +M: Declan Doherty <declan.doherty at intel.com>
> +T: git://dpdk.org/draft/dpdk-draft-ipsec
> +F: lib/librte_security/
> +F: doc/guides/prog_guide/rte_security.rst

Do you really want to keep this draft tree?
If no, please do not reference it.

> +# Compile generic security library
> +#
> +CONFIG_RTE_LIBRTE_SECURITY=y
> +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=n

No, DEBUG config options are prohibited.
The new log system allows to change the log level dynamically.

It was mentioned a lot of time in other patch series.
I was in the hope that everybody was now aware of the new log system
and the desire of removing all DEBUG options.



More information about the dev mailing list