[dpdk-dev] [PATCH] bus: skip useless iterations in rte_bus_find

Ferruh Yigit ferruh.yigit at intel.com
Tue Oct 24 02:18:31 CEST 2017


On 8/29/2017 9:19 AM, Gaetan Rivet wrote:
> The starting point is known. The iterator can be directly set to it.
> 
> The function rte_bus_find can easily be used with a comparison function
> always returning True. This would make it a regular bus iterator.
> 
> Users doing so would however accomplish such iteration in
> 
>    O(N * N/2) = O(N^2)
> 
> Which can be avoided.
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> ---
> 
> In practice, such cost is entirely negligible of course.
> It is cleaner and more correct though.

+1 for more clean approach

Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>


More information about the dev mailing list