[dpdk-dev] [PATCH v10 1/4] librte_flow_classify: add flow classify library

[Iremonger, Bernard]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Tuesday, October 24, 2017 10:51 AM
> To: Iremonger, Bernard <bernard.iremonger at intel.com>
> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>; Ananyev,
> Konstantin <konstantin.ananyev at intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu at intel.com>; adrien.mazarguil at 6wind.com; Singh,
> Jasvinder <jasvinder.singh at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v10 1/4] librte_flow_classify: add flow
> classify library
> 
> Hi,
> 
> Few comments detailed below.
> The new compilation dependencies management needs changes in the
> Makefile.
> And the new log system should be used.

I will send a v11 patch set.
 
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -739,6 +739,13 @@ F: doc/guides/prog_guide/pdump_lib.rst
> >  F: app/pdump/
> >  F: doc/guides/tools/pdump.rst
> >
> > +Flow classify
> > +M: Bernard Iremonger <bernard.iremonger at intel.com>
> > +F: lib/librte_flow_classify/
> > +F: test/test/test_flow_classify*
> > +F: examples/flow_classify/
> > +F: doc/guides/sample_app_ug/flow_classify.rst
> > +F: doc/guides/prog_guide/flow_classify_lib.rst
> 
> I don't how to classify this classify library :) If it is using librte_table, it should
> be part of Packet Framework?

No, it is not intended to be part of Packet Framework.

> If not part of Packet Framework, please move it before "Distributor".

Ok, I will move it to before "Distributor"

 
> The library is missing in the release notes (.so section and new features).

I will add it to the release notes.
 
> > --- a/lib/librte_eal/common/include/rte_log.h
> > +++ b/lib/librte_eal/common/include/rte_log.h
> > @@ -88,6 +88,7 @@ struct rte_logs {
> >  #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
> >  #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */
> >  #define RTE_LOGTYPE_GSO       20 /**< Log related to GSO. */
> > +#define RTE_LOGTYPE_CLASSIFY  21 /**< Log related to flow classify.
> > +*/
> 
> We must stop adding the legacy log types.
> Please switch to dynamic logs and remove
> CONFIG_RTE_LIBRTE_CLASSIFY_DEBUG.

Ok, will do.

> > +CFLAGS += -O3
> > +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
> 
> Now the dependencies to internal libraries must be explicitly declared in
> LDLIBS.

Ok, will do.
 
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -58,6 +58,7 @@ _LDLIBS-y += -L$(RTE_SDK_BIN)/lib  #  # Order is
> > important: from higher level to lower level  #
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY)  += -lrte_flow_classify
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PIPELINE)       += -lrte_pipeline
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)          += -lrte_table
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PORT)           += -lrte_port
> 
> Yes, rte_flow_classify is on top of packet framework.

Regards,

Bernard.