[dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security library

[Akhil Goyal]

Hi Pablo,

On 10/24/2017 8:45 PM, De Lara Guarch, Pablo wrote:
> Hi Akhil,
> 
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal at nxp.com]
>> Sent: Tuesday, October 24, 2017 3:16 PM
>> To: dev at dpdk.org
>> Cc: Doherty, Declan <declan.doherty at intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch at intel.com>; hemant.agrawal at nxp.com; Nicolau,
>> Radu <radu.nicolau at intel.com>; borisp at mellanox.com;
>> aviadye at mellanox.com; thomas at monjalon.net; sandeep.malik at nxp.com;
>> jerin.jacob at caviumnetworks.com; Mcnamara, John
>> <john.mcnamara at intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev at intel.com>; shahafs at mellanox.com;
>> olivier.matz at 6wind.com
>> Subject: [PATCH v5 01/11] lib/rte_security: add security library
>>
> 
> If you are making a v6, I would change the title to "security: ...".
> Also, there is an issue described below.
> 
> Regards,
> Pablo
Ok will change the title "security: introduce security API and framework"

> 
> ...
> 
>> diff --git a/lib/librte_security/Makefile b/lib/librte_security/Makefile new
>> file mode 100644 index 0000000..af87bb2
>> --- /dev/null
>> +++ b/lib/librte_security/Makefile
> 
> ...
> 
>> +
>> +# library name
>> +LIB = librte_security.a
>> +
>> +# library version
>> +LIBABIVER := 1
>> +
>> +# build flags
>> +CFLAGS += -O3
>> +CFLAGS += $(WERROR_FLAGS)
> 
> There is a compilation issue when the building as shared library, because LDLIBS have not been set.
> 
> You need to add the following:
> 
> +LDLIBS += -lrte_eal -lrte_mempool
> 
> 
> 

Thanks for pointing this out. I think it got broken due to some latest 
patches merged. Will correct this in v6.


Thanks,
Akhil