[dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

Thomas Monjalon thomas at monjalon.net
Fri Oct 27 00:03:10 CEST 2017


04/09/2017 15:02, Bruce Richardson:
> Couple of other comments on this code area that should be taken into
> account:
> 1. the indentation of the asm code looks wrong, and should probably be
>    fixed to make it more readable.
> 2. the comment on the "D" register is wrong as it refers to ebx
> 3. the fact that we can't use ebx, and instead use edi and swap twice
>    should be commented.

A patch to fix all these comments would be welcome :)

> For the fix itself:
> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>

Applied (more than one year after the submission), thanks


More information about the dev mailing list