[dpdk-dev] [PATCH] examples/ip_pipeline: avoid the failure of creating hash table

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Fri Oct 27 12:01:38 CEST 2017



> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu at arm.com]
> Sent: Friday, October 27, 2017 3:55 AM
> To: dev at dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu at intel.com>
> Cc: Jianbo Liu <jianbo.liu at arm.com>
> Subject: [PATCH] examples/ip_pipeline: avoid the failure of creating hash
> table
> 
> Hash table function will check if the input bucket size is power of 2,
> so the parameter should be rounded up before sending to the creating
> function.
> 
> Signed-off-by: Jianbo Liu <jianbo.liu at arm.com>
> ---
>  examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c | 2 +-
>  examples/ip_pipeline/pipeline/pipeline_routing_be.c             | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 

Existing code is simply letting the library detect the misconfiguration and gracefully fail. It avoids duplicating library checks in the app.

Your proposal tries to prevent library from failing by silently tweaking some user configuration params. Easier to debug in some cases.

For this case, I am OK with your proposal, although not really required, so:

Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>



More information about the dev mailing list