[dpdk-dev] [PATCH] net/tap: fix invalid queue file descriptor

Ferruh Yigit ferruh.yigit at intel.com
Mon Oct 30 23:55:48 CET 2017


On 10/26/2017 2:51 AM, Pengzhen Liu wrote:
> From: Keith Wiles <keith.wiles at intel.com>
> 
> Rx and Tx queues share the common tap file descriptor, but save this
> value separately.
> 
> Setting up Rx/Tx queue sets up both queues, release_queue close the
> tap file but update file descriptor only for that queue.
> 
> This makes other queue's file descriptor invalid.
> 
> As a workaround, prevent release_queue callback to be called by default.
> 
> This is done by separating Rx/Tx setup functions, so that each only
> setup its own queue, this prevents rte_eth_rx/tx_queue_setup() calling
> release_queue before setup_queue.
> 
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> 
> Signed-off-by: Keith Wiles <keith.wiles at intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>

Hi Pengzhen,

This is a commit from repo :) [1] from beginning of the year.

I assume this has been sent instead of another patch by mistake, please double
check if intended patch sent to mail list.

[1]
http://dpdk.org/commit/0002ca58


More information about the dev mailing list