[dpdk-dev] [PATCH] buildtools: zero elf info variable in pmdinfogen
Bruce Richardson
bruce.richardson at intel.com
Tue Sep 5 15:18:35 CEST 2017
On Tue, Sep 05, 2017 at 02:03:33PM +0100, Harry van Haaren wrote:
> This commit zeros out the elf_info struct at startup of the
> pmdinfogen code. If it is not zeroed, later in the code gcc
> produces "may be unused" prints. Clang does not report any
> issue.
>
> This commit enables a simplification in the meson build
> system, removing the requirement for "-Wno-maybe-uninitialized".
>
> Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
It's worth adding to the commit message that this error only shows up in
optimized builds, which is why the warning is not disabled by default in
the existing makefile.
> ---
>
> buildtools/pmdinfogen/pmdinfogen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
> index ba1a12e..e73fc76 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.c
> +++ b/buildtools/pmdinfogen/pmdinfogen.c
> @@ -397,7 +397,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile)
>
> int main(int argc, char **argv)
> {
> - struct elf_info info;
> + struct elf_info info = {0};
> int rc = 1;
>
> if (argc < 3) {
> --
> 2.7.4
>
More information about the dev
mailing list