[dpdk-dev] [PATCH v2] service: fix service lcore stop function

[Van Haaren, Harry]

> From: Guduri Prathyusha [mailto:gprathyusha at caviumnetworks.com]
> Sent: Wednesday, September 6, 2017 8:16 AM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: dev at dpdk.org; Guduri Prathyusha <gprathyusha at caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v2] service: fix service lcore stop function
> 
> lcore_states store the state of the lcore. Fixing the invalid
> dereference of lcore_states with service number
> 
> Unit test case service_lcore_start_stop fails with the above fix.
> Service core was stopped without stopping the service.
> 
> This commit fixes the test by adding negative and positive cases of
> stopping the service lcore before and after stopping the service
> respectively
> 
> Fixes: 21698354c832 ("service: introduce service cores concept")
> Fixes: f038a81e1c56 ("service: add unit tests")
> 
> Signed-off-by: Guduri Prathyusha <gprathyusha at caviumnetworks.com>

Thanks for fixing and rebase / update to v2. Please mark the v1 of this patchset as "Superseded" in patchwork.

Reviewed-by: Harry van Haaren <harry.van.haaren at intel.com>


> This patch is based on [1]

To be totally clear, this patch depends on the service cores (v2) patchset,
as linked at [1].


> v2 changes:
> - Combined Patch 1/2 and 2/2 of v1
> - Rebased to the future service core patches [1]
> 
> [1] http://dpdk.org/dev/patchwork/patch/27684/