[dpdk-dev] [PATCH v2 02/30] bus/fslmc: remove the export for qbman version function

Hemant Agrawal hemant.agrawal at nxp.com
Fri Sep 8 10:44:59 CEST 2017


This func is not required to be used outside of the qbman driver.

Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
 drivers/bus/fslmc/qbman/include/fsl_qbman_base.h   | 4 ----
 drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 2 --
 drivers/bus/fslmc/qbman/qbman_portal.c             | 7 -------
 drivers/bus/fslmc/qbman/qbman_portal.h             | 1 +
 drivers/bus/fslmc/qbman/qbman_private.h            | 4 ++++
 5 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/drivers/bus/fslmc/qbman/include/fsl_qbman_base.h b/drivers/bus/fslmc/qbman/include/fsl_qbman_base.h
index ee4b772..1415960 100644
--- a/drivers/bus/fslmc/qbman/include/fsl_qbman_base.h
+++ b/drivers/bus/fslmc/qbman/include/fsl_qbman_base.h
@@ -38,10 +38,6 @@ typedef uint64_t  dma_addr_t;
  *
  */
 
-#define QMAN_REV_4000   0x04000000
-#define QMAN_REV_4100   0x04010000
-#define QMAN_REV_4101   0x04010001
-
 /**
  * struct qbman_block_desc - qbman block descriptor structure
  * @ccsr_reg_bar: CCSR register map.
diff --git a/drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h b/drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h
index 9e9047e..23c3d13 100644
--- a/drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h
+++ b/drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h
@@ -1132,6 +1132,4 @@ int qbman_swp_send_multiple(struct qbman_swp *s,
 
 int qbman_check_command_complete(struct qbman_swp *s,
 				 const struct qbman_result *dq);
-
-int qbman_get_version(void);
 #endif /* !_FSL_QBMAN_PORTAL_H */
diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c
index f360760..97df703 100644
--- a/drivers/bus/fslmc/qbman/qbman_portal.c
+++ b/drivers/bus/fslmc/qbman/qbman_portal.c
@@ -105,8 +105,6 @@ struct qb_attr_code code_sdqcr_dqsrc = QB_CODE(0, 0, 16);
 #define MAX_QBMAN_PORTALS  35
 static struct qbman_swp *portal_idx_map[MAX_QBMAN_PORTALS];
 
-uint32_t qman_version;
-
 /*********************************/
 /* Portal constructor/destructor */
 /*********************************/
@@ -1579,8 +1577,3 @@ int qbman_swp_send_multiple(struct qbman_swp *s,
 
 	return sent;
 }
-
-int qbman_get_version(void)
-{
-	return qman_version;
-}
diff --git a/drivers/bus/fslmc/qbman/qbman_portal.h b/drivers/bus/fslmc/qbman/qbman_portal.h
index 7aa1d4f..8018048 100644
--- a/drivers/bus/fslmc/qbman/qbman_portal.h
+++ b/drivers/bus/fslmc/qbman/qbman_portal.h
@@ -29,6 +29,7 @@
 #include "qbman_private.h"
 #include <fsl_qbman_portal.h>
 
+uint32_t qman_version;
 /* All QBMan command and result structures use this "valid bit" encoding */
 #define QB_VALID_BIT ((uint32_t)0x80)
 
diff --git a/drivers/bus/fslmc/qbman/qbman_private.h b/drivers/bus/fslmc/qbman/qbman_private.h
index 292ec6a..b98c330 100644
--- a/drivers/bus/fslmc/qbman/qbman_private.h
+++ b/drivers/bus/fslmc/qbman/qbman_private.h
@@ -171,4 +171,8 @@ static inline void hexdump(const void *ptr, size_t sz)
 	__hexdump(start, end, p, sz, c);
 }
 
+#define QMAN_REV_4000   0x04000000
+#define QMAN_REV_4100   0x04010000
+#define QMAN_REV_4101   0x04010001
+
 #include "qbman_sys.h"
-- 
2.7.4



More information about the dev mailing list