[dpdk-dev] [PATCH v3 2/2] ethdev: introduce Tx queue offloads API

[Shahaf Shuler]

Wednesday, September 13, 2017 11:41 AM, Andrew Rybchenko:

>>+Mbuf fast free

>>+--------------

>>+

>>+Supports optimization for fast release of mbufs following successful Tx.

>>+Requires all mbufs to come from the same mempool and has refcnt = 1.

>It is ambiguous here in the case of fast free configured on port level.
>Please, highlight that "from the same mempool" is per-queue.

OK.




>>+     local_conf = *tx_conf;

>>+     if (tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE)

>>+             rte_eth_convert_txq_offloads(tx_conf->offloads,

>>+                                         &local_conf.txq_flags);

>Is it intended that ignore flag is lost here?
>It mean that failsafe slaves will treat txq_flags as the primary source of offloads
>configuration and do conversion from txq_flags to offloads.
>For example, it means that DEV_TX_OFFLOAD_QINQ_INSERT will be lost as well
>as many other offloads which are not covered by txq_flags.

Right, this is bug. Thanks.