[dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API.

Thomas Monjalon thomas at monjalon.net
Fri Sep 15 17:51:36 CEST 2017


15/09/2017 16:59, Pavan Nikhilesh Bhagavatula:
> On Fri, Sep 15, 2017 at 02:44:57PM +0000, Van Haaren, Harry wrote:

> > > > > We could also choose to add this function to rte_service.h ?
> > > >
> > > > Yes that is an option, and OK with me.
> > > >
> > > > @Pavan what do you think of adding it to service.h, implement in .c and add
> > > to .map?
> > > >
> > >
> > > The ROLE_SERVICE/ROLE_RTE defines the role of a lcore so it made sense to put
> > > it in rte_lcore.h as lcore properties are accessed mostly through this header.
> > > I'm fine with adding it to service.h as suggested by Harry.
> > >
> > > -Pavan
> >
> > *as suggested by Thomas ;)
> >
> > Initially I thought it made more sense in lcore.h too, however the application
> > should only require knowing if core X is a service core if it cares about
> > services / service-cores, hence I'm fine with rte_service.h too.
> >
> > -Harry
> >
> Agreed, will spin up a v2.

The most difficult is to find a good name for this function :)


More information about the dev mailing list