[dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable

Shijith Thotton shijith.thotton at caviumnetworks.com
Mon Sep 18 08:27:22 CEST 2017


On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote:
> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
> lio_dev_atomic_write_link_status(), but is uninitialized.
> 
> v2:
> * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
>   to 'ETH_LINK_AUTONEG'.

Please remove change log from commit message[1] and use --in-reply-to option
while sending new versions of a patch.

1. http://dpdk.org/ml/archives/dev/2017-September/075426.html

> 
> Signed-off-by: Yong Wang <wang.yong19 at zte.com.cn>
> ---

You can move change log here.

>  drivers/net/liquidio/lio_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 479936a..30119d2 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
>  	link.link_status = ETH_LINK_DOWN;
>  	link.link_speed = ETH_SPEED_NUM_NONE;
>  	link.link_duplex = ETH_LINK_HALF_DUPLEX;
> +	link.link_autoneg = ETH_LINK_AUTONEG;
>  	memset(&old, 0, sizeof(old));
>  
>  	/* Return what we found */
> -- 
> 1.8.3.1
> 


More information about the dev mailing list