[dpdk-dev] [PATCH] librte_eal: fix wrong assert for arm and ppc

Jan Viktorin viktorin at rehivetech.com
Thu Sep 21 17:18:50 CEST 2017


On Thu, 21 Sep 2017 15:04:04 +0200
Lukasz Majczak <lma at semihalf.com> wrote:

> The assertion of return value from the open() function is done against
> 0, while it is a correct value - open() returns -1 in case of an error.
> It causes problems while trying to run as a daemon, in which case, this
> call to open() will return 0 as a valid descriptor.

Good catch! Please add also:

Fixes: b94e5c9406b5 ("eal/arm: add CPU flags for ARMv7")
Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
Fixes: 9ae155385686 ("eal/ppc: cpu flag checks for IBM Power")

> 
> Signed-off-by: Lukasz Majczak <lma at semihalf.com>

Acked-by: Jan Viktorin <viktorin at rehivetech.com>


More information about the dev mailing list