[dpdk-dev] [PATCH v4 1/5] net/bonding: remove bonding APIs using ABI versioning

Yang, Zhiyong zhiyong.yang at intel.com
Fri Sep 22 04:02:08 CEST 2017


Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, September 21, 2017 6:37 PM
> To: Yang, Zhiyong <zhiyong.yang at intel.com>; dev at dpdk.org
> Cc: thomas at monjalon.net
> Subject: Re: [PATCH v4 1/5] net/bonding: remove bonding APIs using ABI
> versioning
> 
> On 9/21/2017 9:32 AM, Zhiyong Yang wrote:
> > There are two bonding APIs using ABI versioning, and both have port_id
> > as parameter. Since we are already breaking ABI, no need to keep older
> > versions of APIs.
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>
> 
> <...>
> 
> > -int
> > -rte_eth_bond_8023ad_conf_get_v1708(uint8_t port_id,
> > +rte_eth_bond_8023ad_conf_get(uint8_t port_id,
> >  		struct rte_eth_bond_8023ad_conf *conf)  {
> >  	struct rte_eth_dev *bond_dev;
> > @@ -1409,10 +1320,6 @@ rte_eth_bond_8023ad_conf_get_v1708(uint8_t
> port_id,
> >  	bond_mode_8023ad_conf_get_v1708(bond_dev, conf);
> 
> I am aware this is not focus of the patchset, but it would be good to rename this
> function too and remove _v1708 suffix.
> 
> It seems there is already a function named "bond_mode_8023ad_conf_get"
> and after removed code, "bond_mode_8023ad_conf_get" only called by
> "bond_mode_8023ad_conf_get_v1708":
> 
> bond_mode_8023ad_conf_get_v1708()
>    bond_mode_8023ad_conf_get()
> 
> So it is possible to merge them into name "bond_mode_8023ad_conf_get()"
> 

Ok. I will merge them into one.

> Thanks,
> Ferruh





More information about the dev mailing list