[dpdk-dev] [PATCH] rte_sched: don't count RED-drops as tail-drops

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Mon Sep 25 13:05:37 CEST 2017


> 
> Packets that are RED-dropped are not Tail-dropped, so the n_pkts_dropped
> counter should not be incremented when the n_pkts_red_dropped counter
> is.
> 

Hi Alan,

Not really:
* The n_pkts_dropped counter is intended to be incremented every time a packet is dropped, regardless of the drop cause (either tail drop or RED), so it is cumulative of all drop causes.
* The n_pkts_red_dropped counter is only incremented when the drop cause is RED, so it represents a slice of n_pkts_dropped. Therefore, the number of packets dropped due to tail drop is (n_pkts_dropped - n_pkts_red_dropped).

So NAK.

Thanks,
Cristian



More information about the dev mailing list