[dpdk-dev] [PATCH v3] sched: make RED scaling configurable

[Dewar, Alan]

Hi Cristian,

No problem,  it doesn't sounds like it will be too difficult. 

Unfortunately I'm in the middle of another piece of work, so it will probably be a couple of weeks before I get around to it.

Regards
Alan

-----Original Message-----
From: Dumitrescu, Cristian [mailto:cristian.dumitrescu at intel.com] 
Sent: Monday, September 25, 2017 11:37 AM
To: alangordondewar at gmail.com; Kantecki, Tomasz <tomasz.kantecki at intel.com>
Cc: dev at dpdk.org; Alan Dewar <alan.dewar at att.com>
Subject: RE: [dpdk-dev] [PATCH v3] sched: make RED scaling configurable

<snip>...
 
> diff --git a/config/common_base b/config/common_base index 
> 5e97a08..2626557 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -666,6 +666,13 @@ CONFIG_RTE_SCHED_COLLECT_STATS=n  
> CONFIG_RTE_SCHED_SUBPORT_TC_OV=n
>  CONFIG_RTE_SCHED_PORT_N_GRINDERS=8
>  CONFIG_RTE_SCHED_VECTOR=n
> +#
> +# RTE_RED_SCALING - number of fractional bits used for RED's moving
> average
> +# For every bit that RTE_RED_SCALING is reduced, the max-queue size 
> +can
> doubled
> +# RTE_RED_MAX_TH_MAX = (max-queue size - 1), max-queue size must be
> power of two
> +#
> +CONFIG_RTE_RED_SCALING=10
> +CONFIG_RTE_RED_MAX_TH_MAX=1023
> 

Alan, Tomasz,

Thank you for your work!

We generally want to avoid build-time configuration in favour of run-time configuration. Can you please rework this as run-time configuration?

I suggest we add a new API function to configure these parameters globally for all the RED objects (as opposed to per RED object), with the default values as the current values when this function is not called.

So NACK for now.

Regards,
Cristian