[dpdk-dev] [PATCH v3 08/21] net/virtio: implement receive path for packed queues

[Maxime Coquelin]

Hi Jens,

On 04/05/2018 12:10 PM, Jens Freimann wrote:
> From: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> 
> Implement the receive part here. No support for mergeable buffers yet.
> 
> Signed-off-by: Jens Freimann <jfreimann at redhat.com>
> Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c |  10 ++-
>   drivers/net/virtio/virtio_ethdev.h |   2 +
>   drivers/net/virtio/virtio_rxtx.c   | 137 ++++++++++++++++++++++++++++++++++++-
>   3 files changed, 146 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 089a161ac..dc220c743 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1315,10 +1315,15 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)
>   {
>   	struct virtio_hw *hw = eth_dev->data->dev_private;
>   
> -	if (hw->use_simple_rx) {
> +	/* workarount for packed vqs which don't support mrg_rxbuf at this point */

I don't think you need such workarounds, just advertise the packed ring
layout feature once full support is introduced.

Also I'm not cleat what the workaround is needed here, as you set to
virtio_recv_pkts_packed whatever mrg is on or not.