[dpdk-dev] [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD

[De Lara Guarch, Pablo]

Hi Jay,

> -----Original Message-----
> From: Jay Zhou [mailto:jianjay.zhou at huawei.com]
> Sent: Monday, April 16, 2018 3:21 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Zhang, Roy Fan
> <roy.fan.zhang at intel.com>; thomas at monjalon.net;
> arei.gonglei at huawei.com; Zeng, Xin <xin.zeng at intel.com>;
> weidong.huang at huawei.com; wangxinxin.wang at huawei.com;
> longpeng2 at huawei.com; jianjay.zhou at huawei.com
> Subject: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD
> 
> The virtio crypto device is a virtual cryptography device as well as a kind of
> virtual hardware accelerator for virtual machines. The linux kernel virtio-crypto
> driver has been merged, and this patch introduces virtio crypto PMD to achieve
> better performance.
> 
> Signed-off-by: Jay Zhou <jianjay.zhou at huawei.com>
> Reviewed-by: Fan Zhang <roy.fan.zhang at intel.com>
> Acked-by: Fan Zhang <roy.fan.zhang at intel.com>

...

> +++ b/drivers/crypto/virtio/meson.build
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 HUAWEI
> +TECHNOLOGIES CO., LTD.
> +
> +dep = dependency('libcrypto', required: false) if not dep.found()
> +	build = false
> +endif

Does this PMD have a dependency on libcrypto?
Looking at the code, I don't think it does.
Therefore, you should remove this and also LDLIBS += -lcrypto in the Makefile.
Once this is removed, and you add the path to the virtio_crypto.h file (as Ferruh suggested),
I'd say this PMD can be enabled by default.