[dpdk-dev] [PATCH v3 03/13] e1000: replace rte_panic instances in e1000 driver

Stephen Hemminger stephen at networkplumber.org
Mon Apr 16 17:34:09 CEST 2018


On Fri, 13 Apr 2018 21:30:34 +0300
Arnon Warshavsky <arnon at qwilt.com> wrote:

> +	if (*vfinfo == NULL) {
> +		RTE_LOG(CRIT, PMD, "%s(): Cannot allocate memory for private "
> +				"VF data\n", __func__);
> +		return -1;
> +	}
>  
Don't split strings across lines. Checkpatch should complain about that.
It makes searching for error messages in source harder.

Instead do:
	if (!*vfinfo) {
		RTE_LOG(CRIT, PMD,
			"%s(): Cannot allocate memory for private VF data\n",
			__func__);
		return -1;
	}

Also why not use PMD_DRV_LOG() macro.


More information about the dev mailing list