[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

[Singh, Jasvinder]

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, April 17, 2018 4:01 PM
> To: Singh, Jasvinder <jasvinder.singh at intel.com>
> Cc: dev at dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null
> terminated
> 
> On Tue, Apr 17, 2018 at 02:28:25PM +0100, Jasvinder Singh wrote:
> > The destination string may not have a null termination if the source
> > string's length is equal to the sizeof(pipeline->name).
> >
> > Fix by replacing strncpy with strlcpy that guarantees NULL-termination.
> >
> > Coverty issue: 272606
> > Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
> 
> Does this need an include of rte_string_fns.h?
> 
> In terms of the change itself:
> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> 

It got reference of rte_string_fns.h through other header files there. So build was ok, but I will send v2 with explicit include. Thanks.