[dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function check

[Xueming(Steven) Li]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Wednesday, April 18, 2018 6:01 AM
> To: Xueming(Steven) Li <xuemingl at mellanox.com>
> Cc: dev at dpdk.org; Shahaf Shuler <shahafs at mellanox.com>; Nelio Laranjeiro <notifications at github.com>;
> Wenzhuo Lu <wenzhuo.lu at intel.com>; Jingjing Wu <jingjing.wu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function check
> 
> 17/04/2018 16:24, Xueming Li:
> > +	/* Check that device supports requested rss hash functions. */
> > +	if ((dev_info.flow_type_rss_offloads |
> > +	     dev_conf->rx_adv_conf.rss_conf.rss_hf) !=
> > +	    dev_info.flow_type_rss_offloads) {
> > +		RTE_PMD_DEBUG_TRACE("ethdev port_id=%d invalid rss_hf: 0x%lx, valid value: 0x%lx\n",
> > +				    port_id,
> > +				    dev_conf->rx_adv_conf.rss_conf.rss_hf,
> > +				    dev_info.flow_type_rss_offloads);
> > +		return -EINVAL;
> > +	}
> 
> Please use PRIx64 and test 32-bit compilation.
> 
> Reminder from this recent post:
> 
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fml%2Farchives%2Fdev%2F201
> 8-
> February%2F090882.html&data=02%7C01%7Cxuemingl%40mellanox.com%7C5508bc716aac41b932fb08d5a4aeb241%7Ca65
> 2971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636595992591300475&sdata=1hirZ1j7VqCMnrzngZFAuQj42OACfxFUgYgzy
> VQyw%2F4%3D&reserved=0
> "
> Most of the times, using %l is wrong (except when printing a long).
> So next time you write %l, please think "I am probably wrong".
> "

Thanks, got following warning from checkpatch when applying this rule to my other patchset, is it normal?
  CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
  #49: FILE: drivers/net/mlx5/mlx5_flow.c:2083:
  +               " hash:%" PRIx64 "/%u specs:%hhu(%hu), priority:%hu, type:%d,"