[dpdk-dev] [dpdk-stable] [PATCH 2/3] net/bnxt: check vnic_id before issuing set_rx_mask

[Ajit Khaparde]

On Thu, Apr 19, 2018 at 5:47 PM, Ferruh Yigit <ferruh.yigit at intel.com>
wrote:

> On 4/20/2018 12:57 AM, Ajit Khaparde wrote:
> > In some cases bnxt_hwrm_cfa_l2_set_rx_mask is being called before
> > VNICs are allocated. The FW returns an error in such cases.
> > Prevent sending the command the FW by checking for a valid vnic id
>
> Hi Ajit,
>
> Commit title doesn't explain "why" but explains what has been done. It is
> easier
> to see "what" part from code but not easy to see "why" without
> explanation. Here
> commit log explain the reason and scope, only title doesn't reflect it.
> Title
> can be something like "fix firmware error" ...
>
Yes, Sure. I missed it. ​I was concentrating on keeping the title short.​



> Please check patches with "check-git-log.sh", it will already complain
> about
> title, script complains about "_" to force explaining "why" instead of
> using
> variable/function names.
>
> Previous set you have sent has same problem, they are already in next-net
> but if
> you have bandwidth can you please check them too? If you can send revised
> commit
> log/title
> ​​
> I can update them. "check-git-log.sh" will help to find failing ones.
>
​Will do. Thanks
​


>
> <...>
>
> > @@ -594,7 +590,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev
> *eth_dev)
> >       }
> >       bp->dev_stopped = 0;
> >
> > -     rc = bnxt_init_nic(bp);
> > +     rc = bnxt_init_chip(bp);
>
> Is this bnxt_init_nic()/bnxt_init_chip() changes related to what has been
> described in commit log? If so can you explain in commit log why there are
> related?
>