[dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Tue Apr 24 19:20:15 CEST 2018



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Tuesday, April 24, 2018 4:30 PM
> To: Chalupnik, KamilX <kamilx.chalupnik at intel.com>; dev at dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar at intel.com>; Chalupnik, KamilX
> <kamilx.chalupnik at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups
> 
> Hi,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of KamilX Chalupnik
> > Sent: Tuesday, April 17, 2018 3:40 PM
> > To: dev at dpdk.org
> > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>; Chalupnik, KamilX
> > <kamilx.chalupnik at intel.com>
> > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue
> > Groups
> >
> 
> This patch is mainly an API change, so title should be: "bbdev: split queue
> groups", Since it mainly targets the library (which therefore, requires changes in
> the PMDs and the test app).
> Also the commit message should be updated, not focusing on the Turbo SW
> driver.
> 

Could you also document this API change in release notes?

Thanks,
Pablo

> 
> > Splitting Queue Groups into UL/DL Groups in Turbo Software Driver. The
> > are independent for Decode/Encode
> >
> > Signed-off-by: KamilX Chalupnik <kamilx.chalupnik at intel.com>
> >
> 
> ...
> 
> > -	TEST_ASSERT(event_status == 0,
> > +	TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_UNKNOWN,
> >  			"Failed test for rte_bbdev_pmd_callback_process "
> >  			"for RTE_BBDEV_EVENT_UNKNOWN ");
> 
> These changes making use of the EVENT macros should be in a separate patch,
> as it doesn't look like they belong to this one.
> 



More information about the dev mailing list