[dpdk-dev] [PATCH] app/bbdev: dynamic lib support

[De Lara Guarch, Pablo]

Hi Kamil,

> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Thursday, April 26, 2018 10:42 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; dev at dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> 
> Hi Pablo,
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, April 25, 2018 6:11 PM
> > To: Chalupnik, KamilX <kamilx.chalupnik at intel.com>; dev at dpdk.org
> > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> >
> > Hi Kamil,
> >
> > > -----Original Message-----
> > > From: Chalupnik, KamilX
> > > Sent: Wednesday, April 25, 2018 9:43 AM
> > > To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
> > > dev at dpdk.org
> > > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > >
> > > Hi Pablo
> > >
> > > > -----Original Message-----
> > > > From: De Lara Guarch, Pablo
> > > > Sent: Tuesday, April 24, 2018 4:18 PM
> > > > To: Chalupnik, KamilX <kamilx.chalupnik at intel.com>; dev at dpdk.org
> > > > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>; Chalupnik, KamilX
> > > > <kamilx.chalupnik at intel.com>
> > > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > > >
> > > > Hi Kamil,
> > > >
> > > > > -----Original Message-----
> > > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of KamilX
> > > > > Chalupnik
> > > > > Sent: Wednesday, April 4, 2018 3:06 PM
> > > > > To: dev at dpdk.org
> > > > > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>; Chalupnik, KamilX
> > > > > <kamilx.chalupnik at intel.com>
> > > > > Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > > > >
> > > > > From: "Chalupnik, KamilX" <kamilx.chalupnik at intel.com>
> > > > >
> > > > > Support for linking with dynamic library added in Baseband
> > > > > Device test application
> > > > >
> > > > > Signed-off-by: KamilX Chalupnik <kamilx.chalupnik at intel.com>
> > > > > ---
> > > > >  app/test-bbdev/Makefile        | 4 ++++
> > > > >  doc/guides/tools/testbbdev.rst | 7 +++++++
> > > > >  2 files changed, 11 insertions(+)
> > > > >
> > > > > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile
> > > > > index 6da0c8e..26c9a4b 100644
> > > > > --- a/app/test-bbdev/Makefile
> > > > > +++ b/app/test-bbdev/Makefile
> > > > > @@ -22,4 +22,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) +=
> > > > test_bbdev_vector.c
> > > > >
> > > > >  LDLIBS += -lm
> > > > >
> > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW),y)
> > > > > +LDLIBS += -lrte_pmd_bbdev_turbo_sw endif
> > > >
> > > > This is already done in mk/rte.app.mk, so it should not be needed.
> > > >
> > >
> > > We need this here when DPDK is built as dynamic library.
> > > In rte.app.mk lrte_pmd_bbdev_turbo_sw is added to LDLIBS when
> > > CONFIG_RTE_BUILD_SHARED_LIB is not set.
> >
> > In that case, you need to use the EAL option "-d" with  the .so library.
> >
> > ./testbbdev -d build/lib/librte_pmd_bbdev_turbo_sw.so --vdev="turbo_sw"
> 
> I thought it is fine as long as other test applications works in that way, e.g. test-
> crypto-perf, test-pmd

I think some of them are including the PMDs like what you are doing because these have additional API.
In case of Turbo, it does not have it, and therefore, it is just another driver that can be plugged it in through
"-d" option (notice that most of the PMDs are not doing what you are trying to do, which means that it is not required).

Thanks!
Pablo