[dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

Arnon Warshavsky arnon at qwilt.com
Sun Apr 29 08:23:37 CEST 2018


So will it fail checkpatch in patchwork? I agree with Aaron and Anatoly
> that patches with rte_panic/exit should flag some warning message, but
> the maintainer should have final say. I don't think failing checkpatch
> is the solution for that.
>
Ok. will leave that to the maintainers and change that not to fail


> > I would rather keep the word 'prevents' as an intention declaration that
> > puts the fact that a panic is undesired first, and the technical ability
> > of a maintainer to allow it second.
>
> It's only words, but to me 'prevents' does not indicate that it is
> undesirable - it indicates it is not allowed.
>
They say words create reality, but since we agreed on reality, I'll reword
:)

>
> > Not sure I understand what you meant here. Can you please elaborate?
> >
>
> Sure, I made a patch with an rte_panic and ran checkpatch on a bunch of
> patches. It gave me the name of all the patches except the one with the
> rte_panic.
>
> Got it now. I wasn't using -v .Will fix
Thanks
/Arnon
--


More information about the dev mailing list