[dpdk-dev] [PATCH] vhost: suppress error if numa is not available

Tiwei Bie tiwei.bie at intel.com
Fri Aug 10 05:03:27 CEST 2018


[PATCH] vhost: suppress error if numa is not available

s/numa/NUMA/

Otherwise check-git-log.sh [1] will complain:

Wrong headline lowercase:
        vhost: suppress error if numa is not available

Apart from that,

Reviewed-by: Tiwei Bie <tiwei.bie at intel.com>

[1] https://github.com/DPDK/dpdk/blob/11a1f847d281/devtools/check-git-log.sh#L109

Thanks

On Thu, Aug 09, 2018 at 07:09:38PM +0300, Ilya Maximets wrote:
> It's a common case that 'get_mempolicy' fails on systems
> without NUMA support. No need to flag an error in log for
> this situation.
> 
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> ---
>  lib/librte_vhost/vhost.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
> index 3c9be10..91026b3 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -8,6 +8,7 @@
>  #include <stdint.h>
>  #include <stdlib.h>
>  #ifdef RTE_LIBRTE_VHOST_NUMA
> +#include <numa.h>
>  #include <numaif.h>
>  #endif
>  
> @@ -480,7 +481,7 @@ rte_vhost_get_numa_node(int vid)
>  	int numa_node;
>  	int ret;
>  
> -	if (dev == NULL)
> +	if (dev == NULL || numa_available() != 0)
>  		return -1;
>  
>  	ret = get_mempolicy(&numa_node, NULL, 0, dev,
> -- 
> 2.7.4
> 


More information about the dev mailing list