[dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options

Trahe, Fiona fiona.trahe at intel.com
Fri Aug 10 09:57:31 CEST 2018


Hi Thomas

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Thursday, August 9, 2018 8:49 PM
> To: Trahe, Fiona <fiona.trahe at intel.com>
> Cc: dev at dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options
> 
> 09/08/2018 18:50, Fiona Trahe:
> > Clarified documentation structure between
> > compressedev, cryptodev and common build parts.
> > Clarified build configuration options.
> > Added Testing section.
> > Fixed typos and made some cosmetic improvements.
> >
> > v2 changes
> >  - split into patchset
> 
> I am not sure about the split.
> Usually, when there is no text in the commit log,
> it is a tip that it is not worth to be a separate commit.
> Perhaps, it is good to have this split, but in this case,
> please try to explain the purpose (or reason) of each patch in the commit logs.
> 
> Thanks
> 
With over 200 changed lines in the v1 patch I did this to make it easier for Pablo to review.
I'll add more explanation in the v3.


More information about the dev mailing list