[dpdk-dev] [PATCH] ppc64: fix compilation of when AltiVec is enabled

Takeshi T Yoshimura TYOS at jp.ibm.com
Thu Aug 30 12:52:30 CEST 2018

>宛先: adrien.mazarguil at 6wind.com, dev <dev at dpdk.org>, Gowrishankar
>Muthukrishnan <gowrishankar.m at linux.vnet.ibm.com>, Chao Zhu
><chaozhu at linux.vnet.ibm.com>
>送信元: Christian Ehrhardt 
>送信者: "dev" 
>日付: 2018/08/30 07:00PM
>Cc: Luca Boccassi <bluca at debian.org>, Thomas Monjalon
><thomasm at mellanox.com>, Christian Ehrhardt
><christian.ehrhardt at canonical.com>
>件名: [dpdk-dev] [PATCH] ppc64: fix compilation of when AltiVec is
>The definition of almost any newer standard like --stc=c11 will drop
>__APPLCE_ALTIVEC__ which otherwise would be defined.
>If that is the case then altivec.h will redefine bool to a type
>conflicting with those defined by stdbool.h.
>This breaks compilation of 18.08 on ppc64 like:
>  mlx5_nl_flow.c:407:17: error: incompatible types when assigning to
>  ‘__vector __bool int’ {aka ‘__vector(4) __bool int’} from type
>  in_port_id_set = false;
>Other alternatives were pursued on [1] but they always ended up being
>complex than what would be appropriate for the issue we face.
>Change-Id: I1ed56da954e4951b9d120ca2ac0c0c218b4a0140
>Signed-off-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> .../common/include/arch/ppc_64/rte_memcpy.h           | 11
> 1 file changed, 11 insertions(+)
>diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
>index 75f74897b..0b3b89b56 100644
>--- a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
>+++ b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
>@@ -37,6 +37,17 @@
> #include <string.h>
> /*To include altivec.h, GCC version must  >= 4.8 */
> #include <altivec.h>
>+ * Compilation workaround for PPC64 targets when AltiVec is fully
>+ * enabled e.g. with std=c11. Otherwise there would be a type
>+ * of "bool" between stdbool and altivec.
>+ */
>+#if defined(__PPC64__) && !defined(__APPLE_ALTIVEC__)
>+ #undef bool
>+ /* redefine as in stdbool.h */
>+ #define bool _Bool
> #ifdef __cplusplus
> extern "C" {

I could reproduce the issue you reported in 18.08 with my ppc64le box with RedHat 7.5 and GCC4.8.
The patch resolved the issue in my environment. Thanks!

I am a bit newbie in dpdk-dev, but I will try contacting Chao and other IBM guys... Sorry for our slow reply.


More information about the dev mailing list