[dpdk-dev] [PATCH 3/8] net/mlx5: rename internal function

Adrien Mazarguil adrien.mazarguil at 6wind.com
Fri Aug 31 11:57:32 CEST 2018


Clarify difference between mlx5_nl_flow_create() and mlx5_nl_flow_init()
by renaming the latter mlx5_nl_flow_ifindex_init().

Signed-off-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
---
 drivers/net/mlx5/mlx5.c         | 3 ++-
 drivers/net/mlx5/mlx5.h         | 4 ++--
 drivers/net/mlx5/mlx5_nl_flow.c | 4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 1414ce0c5..9a504a31c 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1139,7 +1139,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
 	priv->mnl_socket = mlx5_nl_flow_socket_create();
 	if (!priv->mnl_socket ||
 	    !priv->ifindex ||
-	    mlx5_nl_flow_init(priv->mnl_socket, priv->ifindex, &flow_error)) {
+	    mlx5_nl_flow_ifindex_init(priv->mnl_socket, priv->ifindex,
+				      &flow_error)) {
 		if (!priv->mnl_socket) {
 			flow_error.message = "cannot open libmnl socket";
 		} else if (!priv->ifindex) {
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 0807cf689..287cfc643 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -408,8 +408,8 @@ int mlx5_nl_flow_create(struct mnl_socket *nl, void *buf,
 			struct rte_flow_error *error);
 int mlx5_nl_flow_destroy(struct mnl_socket *nl, void *buf,
 			 struct rte_flow_error *error);
-int mlx5_nl_flow_init(struct mnl_socket *nl, unsigned int ifindex,
-		      struct rte_flow_error *error);
+int mlx5_nl_flow_ifindex_init(struct mnl_socket *nl, unsigned int ifindex,
+			      struct rte_flow_error *error);
 struct mnl_socket *mlx5_nl_flow_socket_create(void);
 void mlx5_nl_flow_socket_destroy(struct mnl_socket *nl);
 
diff --git a/drivers/net/mlx5/mlx5_nl_flow.c b/drivers/net/mlx5/mlx5_nl_flow.c
index beb03c911..9ea2a1b55 100644
--- a/drivers/net/mlx5/mlx5_nl_flow.c
+++ b/drivers/net/mlx5/mlx5_nl_flow.c
@@ -1154,8 +1154,8 @@ mlx5_nl_flow_destroy(struct mnl_socket *nl, void *buf,
  *   0 on success, a negative errno value otherwise and rte_errno is set.
  */
 int
-mlx5_nl_flow_init(struct mnl_socket *nl, unsigned int ifindex,
-		  struct rte_flow_error *error)
+mlx5_nl_flow_ifindex_init(struct mnl_socket *nl, unsigned int ifindex,
+			  struct rte_flow_error *error)
 {
 	struct nlmsghdr *nlh;
 	struct tcmsg *tcm;
-- 
2.11.0


More information about the dev mailing list