[dpdk-dev] [PATCH 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build

Bruce Richardson bruce.richardson at intel.com
Fri Aug 31 12:17:33 CEST 2018


On Fri, Aug 31, 2018 at 10:20:27AM +0100, Luca Boccassi wrote:
> This PMD is built with -Wno-format, which means GCC errors out if
> -Wformat-security is used.
> 
> Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code")
> 
> Signed-off-by: Luca Boccassi <bluca at debian.org>
> ---
>  drivers/raw/ifpga_rawdev/base/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/ifpga_rawdev/base/meson.build b/drivers/raw/ifpga_rawdev/base/meson.build
> index cb6553521d..aadfc19084 100644
> --- a/drivers/raw/ifpga_rawdev/base/meson.build
> +++ b/drivers/raw/ifpga_rawdev/base/meson.build
> @@ -19,7 +19,7 @@ sources = [
>  
>  error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
>  		'-Wno-format', '-Wno-unused-but-set-variable',
> -		'-Wno-strict-aliasing'
> +		'-Wno-strict-aliasing', '-Wno-error=format-security'

For readability, should format-security be placed right beside the
Wno-format, since both go together? Makes the diff a little bigger, but the
result would be better, I feel.

/Bruce



More information about the dev mailing list