[dpdk-dev] [PATCH v2] malloc: notify primary process about hotplug in secondary

Burakov, Anatoly anatoly.burakov at intel.com
Mon Dec 10 11:49:05 CET 2018


On 07-Dec-18 8:10 PM, Seth Howell wrote:
> When secondary process hotplugs memory, it sends a request
> to primary, which then performs the real mmap() and sends
> sync requests to all secondary processes. Upon receiving
> such sync request, each secondary process will notify the
> upper layers of hotplugged memory (and will call all
> locally registered event callbacks).
> 
> In the end we'll end up with memory event callbacks fired
> in all the processes except the primary, which is a bug.
> 
> This gets critical if memory is hotplugged while a VFIO
> device is attached, as the VFIO memory registration -
> which is done from a memory event callback present in the
> primary process only - is never called.
> 
> After this patch, a primary process fires memory event
> callbacks before secondary processes start their
> synchronizations - both for hotplug and hotremove.
> 
> Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
> 
> Signed-off-by: Seth Howell <seth.howell at intel.com>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk at intel.com>
> ---

Lost my review tag...

Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>

-- 
Thanks,
Anatoly


More information about the dev mailing list