[dpdk-dev] [PATCH v6 1/9] app/procinfo: add usage for new debug
Varghese, Vipin
vipin.varghese at intel.com
Wed Dec 12 16:06:13 CET 2018
> > @@ -83,7 +87,13 @@ proc_info_usage(const char *prgname)
> > " --stats-reset: to reset port statistics\n"
> > " --xstats-reset: to reset port extended statistics\n"
> > " --collectd-format: to print statistics to STDOUT in expected
> by
> > collectd format\n"
> > - " --host-id STRING: host id used to identify the system process
> > is running on\n",
> > + " --host-id STRING: host id used to identify the system process
> > is running on\n"
> > + " --show-port to display ports information\n"
> > + " --show-tm to display traffic manager information for
> ports\n"
> > + " --show-crypto to display crypto information\n"
> > + " --show-ring[=name] to display ring information\n"
> > + " --show-mempool[=name] to display mempool
> information\n"
> > + " --iter-mempool=name to iterate mempool elements\n",
> > prgname);
> > }
> >
>
> Style related comment, add ' :' between command token and token message,
> similar to host-id and other .
>
> Is iter-mempool option, only to iterate only or to display the elements also?
> Then update the help message.
Thanks for sharing this thought, I am clear with the idea this does not convey the complete required message as explained 'Patch 9/9'. Hence I am ready to reword as "" --iter-mempool=name: to iterate mempool elements and display content\n "
>
> Thanks,
> Reshma
More information about the dev
mailing list