[dpdk-dev] [PATCH v3 20/34] net/ice: support link update

Zhang, Qi Z qi.z.zhang at intel.com
Thu Dec 13 09:47:20 CET 2018

Hi Wenzhuo:

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, December 12, 2018 3:00 PM
> To: dev at dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Yang, Qiming
> <qiming.yang at intel.com>; Li, Xiaoyun <xiaoyun.li at intel.com>; Wu, Jingjing
> <jingjing.wu at intel.com>
> Subject: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update
> Add ops link_update.

> +ice_interrupt_handler(void *param)
> +{
> +	struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
> +	struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +	uint32_t oicr;

I saw the patch also enabled interrupt handler, which looks like be independent and not related with the commit log.
It's better to separate it.

More information about the dev mailing list