[dpdk-dev] [PATCH v1 2/4] examples/power: remove mask functions

Burakov, Anatoly anatoly.burakov at intel.com
Thu Dec 13 13:14:15 CET 2018


On 13-Dec-18 12:13 PM, Hunt, David wrote:
> Hi Anatoly,
> 
> On 10/12/2018 12:30 PM, Burakov, Anatoly wrote:
>> On 22-Nov-18 5:02 PM, David Hunt wrote:
>>> since we're moving to allowing greater than 64 cores, the mask functions
>>> that use uint64_t to perform functions on a masked set of cores are no
>>> longer feasable, so removing them.
>>
>> Perhaps "needed" is a better word, rather than "feasible" :)
> 
> 
> Yes, "needed" is probably better. :)
> 
> 
>>
>> Please correct me if i'm wrong, but as of this patch, some of the 
>> functionality is left in half-working state, and this patch should 
>> really be merged with patch 3?
>>
> 
> This patch removes all the mask functions, including the CLI option to 
> call them, so is in a fully working state. I think it should be fine as 
> a standalone patch in the series.

Yep, OK.

(provided you fix the commit message...)

Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>

> 
> 
> Thanks,
> Dave.
> 
> 


-- 
Thanks,
Anatoly


More information about the dev mailing list