[dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11

Yongseok Koh yskoh at mellanox.com
Fri Dec 14 21:10:42 CET 2018


Will take care of this.
Adding Luca for 16.11.

Thanks!
Yongseok Koh

On Dec 9, 2018, at 11:30 PM, Zhang, Qi Z <qi.z.zhang at intel.com<mailto:qi.z.zhang at intel.com>> wrote:

Your understand is correct, I saw the issue happens on both 17.11 and 16.11 both


From: Andrew Rybchenko [mailto:arybchenko at solarflare.com]
Sent: Monday, December 10, 2018 2:57 PM
To: Zhang, Qi Z <qi.z.zhang at intel.com<mailto:qi.z.zhang at intel.com>>; Yongseok Koh <yskoh at mellanox.com<mailto:yskoh at mellanox.com>>
Cc: dev at dpdk.org<mailto:dev at dpdk.org>; Ivan Malov <Ivan.Malov at oktetlabs.ru<mailto:Ivan.Malov at oktetlabs.ru>>
Subject: Incorrectly applied ethdev: fix queue start to 17.11

Hi,

Do I understand correctly that the following patch was incorrectly applied
on 17.11 since changes are done in queue stop functions instead of
queue start functions? If so, could you fix it, please. Also I think it makes
sense to check other stable branches as well.

We observe regressions because of the changeset.

Andrew.

commit d48890a39af7ae5c2d79dad02dd3ea3df8b6db82
Author: Qi Zhang <qi.z.zhang at intel.com><mailto:qi.z.zhang at intel.com>
Date:   Thu Mar 22 20:59:01 2018 +0800

    ethdev: fix queue start

    [ upstream commit 239c9b435ad4abcac89b5d2480a0c21ce8b8288f ]

    Device must be started before start any queue.

    Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")

    Signed-off-by: Qi Zhang <qi.z.zhang at intel.com><mailto:qi.z.zhang at intel.com>
    Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com><mailto:konstantin.ananyev at intel.com>


More information about the dev mailing list