[dpdk-dev] [PATCH v4 07/10] net/ifc: add devarg for LM mode

[Wang, Xiao W]

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Sunday, December 16, 2018 1:21 AM
> To: Wang, Xiao W <xiao.w.wang at intel.com>; Bie, Tiwei <tiwei.bie at intel.com>
> Cc: alejandro.lucero at netronome.com; dev at dpdk.org; Wang, Zhihong
> <zhihong.wang at intel.com>; Ye, Xiaolong <xiaolong.ye at intel.com>
> Subject: Re: [PATCH v4 07/10] net/ifc: add devarg for LM mode
> 
> 
> 
> On 12/14/18 10:16 PM, Xiao Wang wrote:
> > This patch series enables a new method for live migration, i.e. software
> > assisted live migration. This patch provides a device argument for user
> > to choose the methold.
> >
> > When "swlm=1", driver/device will do live migration with a relay thread
> > dealing with dirty page logging. Without this parameter, device will do
> > dirty page logging and there's no relay thread consuming CPU resource.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>
> > ---
> >   drivers/net/ifc/ifcvf_vdpa.c | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
> > index c0e50354a..395c5112f 100644
> > --- a/drivers/net/ifc/ifcvf_vdpa.c
> > +++ b/drivers/net/ifc/ifcvf_vdpa.c
> > @@ -8,6 +8,7 @@
> >   #include <sys/ioctl.h>
> >   #include <sys/epoll.h>
> >   #include <linux/virtio_net.h>
> > +#include <stdbool.h>
> >
> >   #include <rte_malloc.h>
> >   #include <rte_memory.h>
> > @@ -31,9 +32,11 @@
> >   #endif
> >
> >   #define IFCVF_VDPA_MODE		"vdpa"
> > +#define IFCVF_SW_FALLBACK_LM	"swlm"
> 
> 
> The patch looks good, except that I don't like the "swlm" name.
> Maybe we could have something less obscure, even if a little bt longer?
> 
> What about "sw-live-migration"?

Agree with you, making it clear is more reader-friendly than a short name.

Thanks,
Xiao