[dpdk-dev] [PATCH] bbdev: add missing experimental tags
akhil.goyal at nxp.com
Tue Dec 18 11:43:29 CET 2018
On 12/18/2018 4:07 PM, David Marchand wrote:
> Hello Akhil,
> On Fri, Dec 14, 2018 at 1:52 PM Mokhtar, Amr <amr.mokhtar at intel.com> wrote:
>>> -----Original Message-----
>>> From: Neil Horman [mailto:nhorman at tuxdriver.com]
>>> Sent: Friday 14 December 2018 12:36
>>> To: David Marchand <david.marchand at redhat.com>
>>> Cc: Akhil Goyal <akhil.goyal at nxp.com>; dev at dpdk.org; stable at dpdk.org;
>>> tredaelli at redhat.com; Yigit, Ferruh <ferruh.yigit at intel.com>; Mokhtar,
>>> Amr <amr.mokhtar at intel.com>
>>> Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags
>>> On Fri, Dec 14, 2018 at 11:00:17AM +0100, David Marchand wrote:
>>>> On Fri, Dec 14, 2018 at 10:54 AM Akhil Goyal <akhil.goyal at nxp.com>
>>>>> Hi David,
>>>>> I can see that there are other APIs as well which are not marked as
>>>>> experimental like rte_bbdev_dec_op_alloc_bulk
>>>>> rte_bbdev_dec_op_free_bulk, rte_bbdev_enqueue_enc_ops etc.
>> It seems that all APIs defined in rte_bbdev_op.h are missing their
>> experimental tags.
>>>> Well, that's the problem with inlines...
>>>> I don't think we can detect these easily.
>>> We can, if the symbols get added to the version map as they should. But
>>> (as you
>>> note), because these functions are inlines, theres no error thrown for
>>> following that rule.
>> Right, there are some APIs missing in the map file.
>> I am submitting a patch of those functions missing.
> Sorry, did not follow up on this.
> My patch has been marked as "Changes Requested" in pw but Amr volunteered
> to fix those issues.
> How do we proceed, do you want a single fix ? or you can already pick mine.
I believe a single patch should be enough to fix this, it can be either
you or Amr. As of now, none of the patch is complete.
More information about the dev