[dpdk-dev] [PATCH v2 1/3] net/virtio: inline refill and offload helpers

Jens Freimann jfreimann at redhat.com
Wed Dec 19 10:25:04 CET 2018


On Tue, Dec 11, 2018 at 02:48:02PM +0100, Maxime Coquelin wrote:
>Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
>---
> drivers/net/virtio/virtio_rxtx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
>index eb891433e..e1c270b1c 100644
>--- a/drivers/net/virtio/virtio_rxtx.c
>+++ b/drivers/net/virtio/virtio_rxtx.c
>@@ -741,7 +741,7 @@ virtio_dev_tx_queue_setup_finish(struct rte_eth_dev *dev,
> 	return 0;
> }
>
>-static void
>+static inline void
> virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m)
> {
> 	int error;
>@@ -757,7 +757,7 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m)
> 	}
> }
>
>-static void
>+static inline void
> virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m)
> {
> 	int error;
>@@ -769,7 +769,7 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m)
> 	}
> }
>
>-static void
>+static inline void
> virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf)
> {
> 	uint32_t s = mbuf->pkt_len;
>@@ -811,7 +811,7 @@ virtio_rx_stats_updated(struct virtnet_rx *rxvq, struct rte_mbuf *m)
> }
>
> /* Optionally fill offload information in structure */
>-static int
>+static inline int
> virtio_rx_offload(struct rte_mbuf *m, struct virtio_net_hdr *hdr)
> {
> 	struct rte_net_hdr_lens hdr_lens;

since these are all static functions, does declaring them inline
actually help or are they inlined anyway by the compiler?

regards,
Jens 


More information about the dev mailing list