[dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

Gavin Hu (Arm Technology China) Gavin.Hu at arm.com
Thu Dec 20 15:40:18 CET 2018


>> > On Thu, Dec 20, 2018 at 1:47 PM David Marchand <mailto:david.marchand at redhat.com> wrote:
>> > On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu <mailto:gavin.hu at arm.com> wrote:
>>>  remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the implementation
>>>  to the arm specific file, x86 and POWER have their own implementations.

>> No, x86 and ppc define their own implementation when _not_ having RTE_FORCE_INTRINSICS.

> Actually, I wondered in the past if we realled needed those double implementations...
> Is there really a point in maintaining both ? I am pretty sure people only use the default configuration per architecture.
> David Marchand

X86 implementation is xchg instruction based, it is arch specific.
Ppc has its own code base, but in reality it is same as arm implementation, but in future, arm will change to its own instruction level based implementation. 


More information about the dev mailing list