[dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file
david.marchand at redhat.com
Thu Dec 20 16:09:43 CET 2018
On Thu, Dec 20, 2018 at 3:36 PM Gavin Hu (Arm Technology China) <
Gavin.Hu at arm.com> wrote:
> >> On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu <mailto:gavin.hu at arm.com>
> >> remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the
> >> to the arm specific file, x86 and POWER have their own implementations.
> > No, x86 and ppc define their own implementation when _not_ having
> > David Marchand
> Hi David,
> Your reply is out of format, I re-format it to text based.
I suppose this is an issue with your mail client.
> Yes, x86 and ppc define their own implementation, so this change is arm
> Only arm have RTE_FORCE_INTRINSICS, x86 and ppc don't define it in the
> config files.
This change breaks the use of intrinsics in x86 case at least.
$ git reset --hard origin/master
HEAD is now at 476c847 malloc: add option --match-allocations
$ git am
Applying: spinlock: move the implementation to arm specific file
# default config
$ rm -rf master; make defconfig O=master && make -j4 O=master
Build complete [x86_64-native-linuxapp-gcc]
# then enable use of intrinsics
$ echo CONFIG_RTE_FORCE_INTRINSICS=y >> master/.config && make O=master
In file included from
error: ‘rte_spinlock_lock’ used but never defined [-Werror]
error: ‘rte_spinlock_unlock’ used but never defined [-Werror]
rte_spinlock_unlock (rte_spinlock_t *sl);
error: ‘rte_spinlock_trylock’ used but never defined [-Werror]
rte_spinlock_trylock (rte_spinlock_t *sl);
cc1: all warnings being treated as errors
make: *** [eal.o] Error 1
make: *** [eal] Error 2
More information about the dev