[dpdk-dev] [PATCH] hash: fix out-of-bound write while freeing key slot

Thomas Monjalon thomas at monjalon.net
Fri Dec 21 01:47:18 CET 2018


20/12/2018 14:59, Bruce Richardson:
> On Wed, Nov 21, 2018 at 08:51:56PM -0600, Honnappa Nagarahalli wrote:
> > Add a debug check for out-of-bound write while freeing the key slot.
> > 
> > Coverity issue: 325733
> > Fixes: e605a1d36ca7 ("hash: add lock-free r/w concurrency")
> > Cc: honnappa.nagarahalli at arm.com
> > 
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> > Reviewed-by: Steve Capper <steve.capper at arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu at arm.com>
> > ---
> >  lib/librte_hash/rte_cuckoo_hash.c |  4 ++++
> >  lib/librte_hash/rte_cuckoo_hash.h | 11 +++++++++++
> >  2 files changed, 15 insertions(+)
> > 
> While I think enqueuing a free slot should ever fail, I don't see an issue
> with having a check for that.
> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>

Applied, thanks




More information about the dev mailing list