[dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD

Trahe, Fiona fiona.trahe at intel.com
Fri Dec 21 18:44:38 CET 2018


Hi Pablo,

Thanks for reviewing

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, December 21, 2018 4:52 AM
> To: Trahe, Fiona <fiona.trahe at intel.com>; dev at dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang at intel.com>; akhil.goyal at nxp.com
> Subject: RE: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
> 
> 
> 
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, December 21, 2018 12:02 AM
> > To: dev at dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Trahe, Fiona
> > <fiona.trahe at intel.com>; Zhang, Roy Fan <roy.fan.zhang at intel.com>;
> > akhil.goyal at nxp.com
> > Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni
> > mb PMD
> >
> > Remove AESNI_MB flag from SGL test cases which it doesn't support.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe at intel.com>
> 
> Patch looks good, but I wonder if this is a fix and therefore, if it needs to be backported.
[Fiona] It did previously print a message saying the device doesn't support
 the test case, so I think more of a style change than a bug. I think this way is clearer but
not necessary to backport cause only really of interest to developers and
dev of new test cases are usually done on latest.

> 
> Thanks,
> Pablo


More information about the dev mailing list