[dpdk-dev] [PATCH 10/14] vhost: vring address setup for packed queues
Maxime Coquelin
maxime.coquelin at redhat.com
Thu Feb 1 10:16:46 CET 2018
Hi Jens,
On 01/29/2018 03:11 PM, Jens Freimann wrote:
> From: Yuanhan Liu <yuanhan.liu at linux.intel.com>
>
> Add code to set up packed queues when enabled.
>
> Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> Signed-off-by: Jens Freimann <jfreiman at redhat.com>
> ---
> lib/librte_vhost/vhost.c | 4 ++++
> lib/librte_vhost/vhost.h | 1 +
> lib/librte_vhost/vhost_user.c | 17 ++++++++++++++++-
> 3 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
> index 1dd9adbc7..78913912c 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -536,6 +536,9 @@ rte_vhost_enable_guest_notification(int vid, uint16_t queue_id, int enable)
> {
> struct virtio_net *dev = get_device(vid);
>
> + if (dev->features & (1ULL << VIRTIO_F_PACKED))
> + return 0;
> +
This check should be done after dev is checked non-null.
> if (dev == NULL)
> return -1;
>
> @@ -545,6 +548,7 @@ rte_vhost_enable_guest_notification(int vid, uint16_t queue_id, int enable)
> return -1;
> }
>
> +
Trailing line.
> dev->virtqueue[queue_id]->used->flags = VRING_USED_F_NO_NOTIFY;
> return 0;
> }
More information about the dev
mailing list