[dpdk-dev] [PATCH] ether: fix incorrect stats query for lowest xstat id

Ferruh Yigit ferruh.yigit at intel.com
Tue Feb 6 18:42:19 CET 2018


On 2/6/2018 4:06 PM, Bruce Richardson wrote:
> When querying either the name or the value of a stat using the xstats
> APIs, a check is done to see if the regular stats API or the xstats APIs
> for the driver need to be used. However, the id of the stat requested is
> checked to see if it is greater than the number of basic stats, rather
> than checking for greater-or-equal, meaning that the xstat with the lowest
> id gets incorrectly treated as a basic stat.
> 
> This problem manifests itself when you call proc_info using "--xstats-id"
> for the first xstat, you get no name of the stat printed, and a random(ish)
> stat value.
> 
> Fixes: 4773152f850b ("ethdev: optimize xstats by ids APIs")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>


More information about the dev mailing list