[dpdk-dev] [PATCH 3/7] cxgbe: add support to update RSS hash configuration and key

Rahul Lakkireddy rahul.lakkireddy at chelsio.com
Wed Feb 7 08:01:46 CET 2018


On Tuesday, February 02/06/18, 2018 at 16:08:35 +0530, Thomas Monjalon wrote:
> 06/02/2018 11:11, Ferruh Yigit:
> > On 2/6/2018 9:22 AM, Rahul Lakkireddy wrote:
> > > On Monday, February 02/05/18, 2018 at 22:39:55 +0530, Ferruh Yigit wrote:
> > >> I tend to get driver patches even after integration deadline, mainly because of
> > >> their limited scope.
> > >> But since these are new features, submitted just before rc3, adding with
> > >> questions in first patch, I am for postponing this patchset to next release and
> > >> do more review, what do you think?
> > > 
> > > Does dpdk-next-net tree work similar to linux "next" trees?  I mean does
> > > it represent the next release (DPDK 18.05-rc1) merge window?  Can we
> > > explicitly mention in Patch title which tree it is targeted for viz.
> > > dpdk or dpdk-next-net?
> > 
> > Hi Rahul,
> > 
> > It is not like Linux next trees, this is more like Dave's net tree.
> > In dpdk responsibilities split into sub-trees, and all target current release,
> > patches merged into sub-trees and pulled by main tree in integration deadline.
> > 
> > All network drivers and ethdev abstraction layer patches goes into next-net
> > sub-tree.
> > 
> > 
> > Briefly overall process is [1]:
> > - A new feature needs to be sent before proposal deadline, this can be a full
> > version of the set or RFC. Proposal deadline for the release announced in
> > https://dpdk.org/dev/roadmap
> > 
> > - After that point code reviews done and new versions sent till integration
> > deadline. Accepted patches are integrated to release candidate 1 (rc1).
> > Of course patch can be reviewed and merged without waiting integration deadline.
> > If a patch not get an approval and merge into tree in integration deadline,
> > most probably it won't go into release.
> > 
> > - Fixes can be sent from beginning of release to rcX. Only latest rcX mostly for
> > the fixes on features introduced in that release.
> > 
> > - After rc1, code tested and fixes sent for found defects. No new feature
> > expected after rc1.
> > 
> > - We go mostly to rc3 or rc4 before release.
> > 
> > 
> > [1]
> > Thomas, please correct me if I missed something. And this needs to be documented
> > indeed.
> 
> If the patchset targets 18.05, it should be notified.
> I suggest --subject-prefix='PATCH 18.05'.
> Then it will be marked as Deferred in patchwork until the start of
> the 18.05 release cycle.
> We can review it but we do not apply it before the start of the cycle,
> because we don't see a real need for such "in advance" branch.
> 

Thank you Ferruh and Thomas for explaining workings/role of
dpdk-next-net tree.

I will wait for few more days to get reviews on patch related to
multiprocess.  And then, will re-submit the series as v2 once
dpdk-18.02 gets released.

Thanks,
Rahul


More information about the dev mailing list