[dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions

[Nelio Laranjeiro]

On Wed, Jan 03, 2018 at 07:21:58AM -0800, Stephen Hemminger wrote:
> On Wed, 3 Jan 2018 08:35:23 +0100
> Nelio Laranjeiro <nelio.laranjeiro at 6wind.com> wrote:
> 
> > Hi Stephen,
> > 
> > On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote:
> > > Since wait_to_complete is unused, don't pass it to helper functions.
> > > Use the standard RTE macro to indicate this is an unused parameter.  
> > 
> > I would suggest to use the (void) as it is done in the whole driver, a
> > specific patch should be done to use the rte_unused macro in all the
> > sources at once.
> > 
> > Thanks,
> > 
> 
> There is a standard in DPDK using RTE macros. The whole driver should
> follow that rather than trying to be different.

The standard was introduced after the driver have been submitted, I
agree that a new way is present, but when it was introduced a
modification on the whole code though DPDK should have been done to
avoid mixed ways.

I prefer to have a single commit replacing the (void)foo by
__rte_unused, it will also help the backports to the stable branches.

Thanks,

-- 
Nélio Laranjeiro
6WIND