[dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf PMD

Lu, Wenzhuo wenzhuo.lu at intel.com
Tue Jan 9 02:35:20 CET 2018


Hi Stephen,

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Monday, January 8, 2018 11:28 PM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> Cc: dev at dpdk.org; Wu, Jingjing <jingjing.wu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf
> PMD
> 
> On Mon, 8 Jan 2018 01:06:36 +0000
> "Lu, Wenzhuo" <wenzhuo.lu at intel.com> wrote:
> 
> > > This function is way to big to be an inline.
> > Thanks for your comments. Let me explain. This is the base code, like
> what's in ixgbe, i40e ... We have to let it be so it's much easier for us to
> update it the next time. That's why the code style is a little different. And
> also some checkpatch problem not handled.
> > We have had some discussion about the copyright license here and
> internally. But unfortunately we don't achieve a conclusion internally so we
> have to keep the long license now and may change it later.
> 
> 
> If you have to have base code then put it in a subdirectory base/ that way
> reviewers and maintainers can separate DPDK part from ugly stuff.
Yes, that's we've done. And we also use an individual patch for it :)


More information about the dev mailing list